Expand sidebar element based on pathname #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now visit any page and the correct category will be expanded. This is done by using the url pathname to determine which category we're currently in, instead of it being passed down as prop.
ivarnakken
added
review-needed
ABA-277 Sidebar elements should expand based on url path
As an example; if you visit https://abakus.no/pages/komiteer/11, it won't expand the "Komiteer" element, event though it should. |
eikhr
added
approved
erlingfn
deleted the
ivarnakken/aba-277-sidebar-elements-should-expand-based-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You can now visit any page and the correct category will be expanded.
This is done by using the url pathname to determine which category we're currently in, instead of it being passed down as prop.
Result
Screen.Recording.2023-02-13.at.21.55.27.mov
Testing
Tested for "info-om-abakus" (which is an edge case), and for when you're not logged in.