Validate user allergy input #3573
Conversation
ivarnakken
added
review-needed
| <Field | ||
| label="Matallergier/preferanser" | ||
| parse={(value) => value} |
There was a problem hiding this comment.
Could you explain why this is necessary? I don't doubt that it is, but does seem a bit weird.
There was a problem hiding this comment.
When updating your user settings, you perform a PATCH request, and react-final-form therefore removes empty values. This means that if you remove your allergies from something to nothing, it won't be patched. This overrides their default parser, so that empty values are kept.
There was a problem hiding this comment.
I see, this is good to know!
It's surprisingly common for people to write "ingen/nei".
ivarnakken
force-pushed
the
ivarnakken/aba-234-give-user-warning-when-typing
branch
from
0da9d75
to
e3499bc
Compare
ivarnakken
added
approved
| message = 'La feltet stå tomt hvis du ikke har noen allergier/preferanser' | ||
| ) => | ||
| (value: string) => { | ||
| const notValidAnswers = ['ingen', 'ingenting', 'nei', 'nope', 'nada']; |
There was a problem hiding this comment.
I believe we should also include "nay", "nah" and "negative" :)
There was a problem hiding this comment.
Are there any examples of people entering them in the allergies field?
| (value: string) => { | ||
| const notValidAnswers = ['ingen', 'ingenting', 'nei', 'nope', 'nada']; | ||
|
|
||
| return [!notValidAnswers.includes(value.toLowerCase()), message]; |
There was a problem hiding this comment.
Could you explain how this syntax works! It looks interesting :)
There was a problem hiding this comment.
Not sure which part you're referring to. The validator needs an array with two values; a boolean and a message. The boolean indicates if the validation has passed or not, and the message is what is given to the user. What we're actually creating here is a function returning a function which returns the array.
ivarnakken
deleted the
ivarnakken/aba-234-give-user-warning-when-typing
branch
Description
It's surprisingly common for people to write "ingen/nei".
Result
Testing
Tested with and without valid inputs.