Make the validator actually validate #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvigHz
added
enhancement
LudvigHz
requested review from
eikhr,
norbye,
danielyanghansen and
ivarnakken
norbye
approved these changes
Feb 16, 2023
| sound.play(); | ||
| showCompleted(); | ||
| (user: User) => { | ||
| console.log(user); |
There was a problem hiding this comment.
I assume this is only here for testing?
There was a problem hiding this comment.
Ooops. Removed, thanks :)
Previously it only checked if you had a user, and the qr did nothing at all. With this change, we validate that the user is a member of Abakus and the QR scanner also displays success or error messages for validation status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously it only checked if you had a user, and the qr did nothing at
all. With this change, we validate that the user is a member of Abakus
and the QR scanner also displays success or error messages for
validation status.
On error, it just gives an alert. I would make it nicer if I had time. But the alert works great tbh. It makes sure that the person validating needs to confirm the message before continuing. Not very fancy but effective.
All the other changed files are just related typing improvements.
Result
User is not member of Abakus:
Screencast.from.2023-02-16.18-11-01.webm
User does not exist (only makes sense for QR):
Screencast.from.2023-02-16.18-16-03.webm
Successful validation:
Screencast.from.2023-02-16.18-24-01.webm
Testing