Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite quote form to react-final-form #3589

Merged
merged 1 commit into from Feb 22, 2023
Merged

Rewrite quote form to react-final-form #3589

merged 1 commit into from Feb 22, 2023

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Feb 18, 2023 •
edited

Description

Rewrote from redux-form to react-final-form. Also changed from TextAreas to TextInput.

Result

Before:
Screenshot 2023-02-18 at 21 07 30

After:
Screenshot 2023-02-18 at 21 07 49

Testing

  • I have thoroughly tested my changes.

I added a quote

Resolves ABA-55

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 18, 2023
@ivarnakken ivarnakken added chore Pull requests that does something "boring", yet important, e.g. cleaning up code review-needed Pull requests that need review and removed review-needed Pull requests that need review labels Feb 18, 2023
ollfkaih
ollfkaih approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@ollfkaih ollfkaih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linear
Copy link

linear bot commented Feb 18, 2023

ABA-55 react-final-form in quote form

@webkom webkom deleted a comment from linear bot Feb 18, 2023
ivarnakken
ivarnakken approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: lgtm

@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Feb 18, 2023
LudvigHz
LudvigHz approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/routes/quotes/components/AddQuote.tsx
pristine: boolean;
submitting: boolean;
handleSubmit: (arg0: (arg0: Record<string, any>) => Promise<any>) => void;
addQuotes: (quote: { text: string; source: string }) => Promise<unknown>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the actual return type here? Or void if you're unsure. It's better then unknown when you know you don't use it IMO.

@LudvigHz
Copy link
Member

I preferred the textarea though

@ivarnakken ivarnakken merged commit b4b43eb into master Feb 22, 2023
@ivarnakken ivarnakken deleted the quote-final-form branch February 22, 2023 12:19
@ivarnakken
Copy link
Member

I need this 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz LudvigHz approved these changes

@ollfkaih ollfkaih ollfkaih approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

@AdrianAndersen AdrianAndersen Awaiting requested review from AdrianAndersen

@Arashfa0301 Arashfa0301 Awaiting requested review from Arashfa0301

@danielyanghansen danielyanghansen Awaiting requested review from danielyanghansen

@EliHaugu EliHaugu Awaiting requested review from EliHaugu

@iselinee iselinee Awaiting requested review from iselinee

Assignees

@eikhr eikhr

Labels
approved Pull requests that have been approved chore Pull requests that does something "boring", yet important, e.g. cleaning up code
Projects
None yet
Milestone
No milestone
4 participants
@eikhr @LudvigHz @ivarnakken @ollfkaih