Create TextWithIcon component #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingraso
added
enhancement
ABA-293 Create TextWithIcon component
At the moment, we have the same layout of having an icon next to some textual content. Therefore, this should be generalized into a separate component that can be used throughout the webapp. An example of usage: |
ollfkaih
requested changes
Feb 18, 2023
ivarnakken
approved these changes
Feb 19, 2023
To generalize the usage of text together with icons. At the moment we have a lot of different ways of doing this.
ingraso
force-pushed
the
aba-293-create-textwithicon-component
branch
from
01cae5a
to
76e6d63
Compare
Previously it could only be ReactElement, but it should also accept a simple string for simplicity reasons.
ingraso
force-pushed
the
aba-293-create-textwithicon-component
branch
from
76e6d63
to
8e273b7
Compare
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Text is displayed with icons throughout the whole webapp. However, there is no component or common way of doing this. With the
<TextWithIcon />component there is now a generalized component that can be used for this purpose. An example of usage can be seen here:There should be no visual changes to the text with icons.
Also fixes some TS errors and moves the tooltip on
<EventDetail />to be on the icon rather than the text.Result
Before
After
Testing
Tested by clicking through where changes have been done.
Resolves ABA-293