Rewrite PollEditor to React-final-form #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollfkaih
requested review from
ivarnakken,
eikhr,
LudvigHz,
Arashfa0301,
danielyanghansen and
erlingfn
ollfkaih
added
the
future-was-2-years-ago
ivarnakken
added
the
chore
ollfkaih
force-pushed
the
poll-editor-final-form
branch
from
e7a48d5
to
6b160fc
Compare
ivarnakken
approved these changes
Feb 18, 2023
ollfkaih
force-pushed
the
poll-editor-final-form
branch
from
6b160fc
to
1081d59
Compare
ivarnakken
added
approved
ivarnakken
reviewed
Feb 19, 2023
Comment on lines
23
to
26
| import type { | ||
| fieldArrayMetaPropTypes, | ||
| fieldArrayFieldsPropTypes, | ||
| } from 'redux-form'; | ||
| } from 'react-final-form'; |
There was a problem hiding this comment.
react-final-form does not export these types. However, I don't seem to find them in redux-form neither ... Has this ever worked?
There was a problem hiding this comment.
Probably existed in the flow type definitions
ollfkaih
force-pushed
the
poll-editor-final-form
branch
from
1081d59
to
b093827
Compare
ollfkaih
force-pushed
the
poll-editor-final-form
branch
from
b093827
to
a9862d1
Compare
ollfkaih
force-pushed
the
poll-editor-final-form
branch
from
a9862d1
to
8b07442
Compare
Add frontend validation for required fields in the poll editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Literally the title
Result
No visual changes 馃
Testing
Resolves ABA-56