Edit company interest #3608
Merged
Edit company interest #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arashfa0301
added
priority:high
Arashfa0301
requested review from
eikhr,
LudvigHz,
juniwbjerde and
ivarnakken
ivarnakken
requested changes
Feb 21, 2023
Comment on lines
161
to
165
| .checkboxSpan { | ||
| display: flex; | ||
| gap: 4px; | ||
| align-items: center; | ||
| } |
There was a problem hiding this comment.
Use the <Flex /> component instead.
There was a problem hiding this comment.
And, are you sure it is even needed?
Comment on lines
+157
to
+159
| ion-icon { | ||
| font-size: 20px; | ||
| } |
There was a problem hiding this comment.
Use classnames instead of generic tags, as it may affect other icons unexpectedly.
There was a problem hiding this comment.
Just use the size prop on the <Icon /> component for this though.
Arashfa0301
force-pushed
the
edit-company-interest
branch
3 times, most recently
from
9977488
to
a2a6c8f
Compare
erlingfn
requested changes
Feb 21, 2023
eikhr
force-pushed
the
edit-company-interest
branch
from
a2a6c8f
to
d3f7069
Compare
Co-authored-by: Jonas de Luna Skulberg <jonasdls@gmail.com>
eikhr
force-pushed
the
edit-company-interest
branch
from
d3f7069
to
c87d8e2
Compare
Arashfa0301
force-pushed
the
edit-company-interest
branch
from
c87d8e2
to
62494b4
Compare
ivarnakken
reviewed
Feb 21, 2023
| @@ -20,7 +20,7 @@ | |||
| "test:coverage": "yarn run test -- --coverage", | |||
| "test:watch": "yarn run test --watch", | |||
| "lint": "yarn run lint:js && yarn run lint:css && yarn run lint:prettier", | |||
| "lint:js": "eslint . --ignore-path .prettierignore --max-warnings 1075", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edited company interest page with long awaited features that were requested by "interkom".
The backend side of all above charges have been implemented and there already exists a pull request for them.
Result
after
Testing
We have thoroughly tested our changes on the webside. We tested that the newly created field and checkboxes work properly and actually push the data to the backend. And also that the newly edited data show up after reopening the form