Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit interest form event type field describers #3614

Merged
merged 1 commit into from Feb 22, 2023
Merged

Conversation

Arashfa0301
Copy link
Contributor

Description

Moved interest form event type field describers from below the description to above the description as requested by "interkom"

Result

before:
image

before:
image

Testing

I have thoroughly tested my changes on window and app

@Arashfa0301 Arashfa0301 self-assigned this Feb 22, 2023
@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 22, 2023
@Arashfa0301 Arashfa0301 added priority:high Pull requests that have high priority, and should therefore be prioritized small-fix Pull requests that fix something small labels Feb 22, 2023
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better if it was an actual label, but this works

@eikhr eikhr merged commit e6c2f8d into master Feb 22, 2023
@eikhr eikhr deleted the edit-interest-form branch February 22, 2023 23:18
@@ -162,3 +162,7 @@ ion-icon {
text-transform: initial;
font-weight: initial;
}

.label {
color: rgb(194, 69, 56);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an existing variable for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to click "submit" on my review yesterday sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high Pull requests that have high priority, and should therefore be prioritized review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
3 participants