Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "cannot load before initialization" error #3617

Merged
merged 1 commit into from Feb 24, 2023
Merged

Conversation

LudvigHz
Copy link
Member

Description

This broke SSR on events. lodash-es does some special stuff with
aliasing that is not supported on SSR (see config.client.js), thus
breaking the dynamic importing of loadable.

Result

SSR on eventDetail works.

Testing

  • I have thoroughly tested my changes.

Resolves ABA-297

This broke SSR on events. lodash-es does some special stuff with
aliasing that is not supported on SSR (see config.client.js), thus
breaking the dynamic importing of loadable.
@LudvigHz LudvigHz added flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution! priority:high Pull requests that have high priority, and should therefore be prioritized review-needed Pull requests that need review bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small labels Feb 24, 2023
@linear
Copy link

linear bot commented Feb 24, 2023

@LudvigHz LudvigHz merged commit 4febf6c into master Feb 24, 2023
@LudvigHz LudvigHz deleted the event-lodash-es branch February 24, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug flawless Pull requests with "flawless" code, e.g. formatting or simple renaming. Should be used with caution! priority:high Pull requests that have high priority, and should therefore be prioritized review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
1 participant