Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct symbol on EvenStatus-component #3626

Merged
merged 1 commit into from Mar 4, 2023
Merged

Conversation

PeterJFB
Copy link
Contributor

Description

Someone pointed out an event with infinite number of places showed x/0 in the listrings-views

Result

Used code from the same file (line 78)

Before:
Screenshot from 2023-02-28 11-32-09

After:
Screenshot from 2023-02-28 11-31-57

Testing

  • I have thoroughly tested my changes.

Inspected images above, and made sure the other event-items looked the same:)


@PeterJFB PeterJFB added the enhancement Pull requests that make enhancements, instead of just purely new features label Feb 28, 2023
@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 28, 2023
@ivarnakken
Copy link
Member

ivarnakken commented Feb 28, 2023

Would it be better to just say "65 påmeldte"? I feel like the infinite symbol might be redundant.

I don't know, this is good though.

@LudvigHz LudvigHz added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Feb 28, 2023
@LudvigHz LudvigHz merged commit fc7e6e3 into master Mar 4, 2023
@LudvigHz LudvigHz deleted the fix-eventstatus-symbol branch March 4, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features
Projects
None yet
3 participants