Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wrongly Colored Event Pills #3649

Merged
merged 1 commit into from Mar 14, 2023
Merged

Fix Wrongly Colored Event Pills #3649

merged 1 commit into from Mar 14, 2023

Conversation

falbru
Copy link
Contributor

@falbru falbru commented Mar 7, 2023 •
edited by ivarnakken

Result

Before
image
After
image

Testing

  • I have thoroughly tested my changes.

@falbru falbru added bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small labels Mar 7, 2023
@falbru falbru requested a review from ivarnakken March 7, 2023 19:23
@github-actions github-actions bot added the review-needed Pull requests that need review label Mar 7, 2023
ivarnakken
ivarnakken approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivarnakken
Copy link
Member

@haukkagu, you need to lint this with prettier😁

@ivarnakken
Copy link
Member

@haukkagu
Cypress is failing on CI because your branch does not have the fix. Just rebase on top of master and we're good.

@ivarnakken ivarnakken added approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged and removed review-needed Pull requests that need review labels Mar 14, 2023
@ivarnakken ivarnakken merged commit d8f646f into master Mar 14, 2023
@ivarnakken ivarnakken deleted the fix-calendar-bug branch March 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz LudvigHz approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

Assignees
No one assigned
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug ready-to-merge Pull requests that have been approved and are ready to be merged small-fix Pull requests that fix something small
Projects
None yet
Milestone
No milestone
3 participants
@falbru @ivarnakken @LudvigHz