Stop event editor from breaking in dev #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
review-needed
ABA-323 Not possible to edit events in dev
kinda possible, if you wait a couple of seconds … very weird behaviour |
ivarnakken
force-pushed
the
ivarnakken/aba-323-not-possible-to-edit-events-in-dev
branch
from
2708347
to
c902c63
Compare
There was problems with storing non-serializble moment objects in the redux store. Issue is fixed by turning event dates into ISO strings.
ivarnakken
force-pushed
the
ivarnakken/aba-323-not-possible-to-edit-events-in-dev
branch
from
c902c63
to
a144eed
Compare
erlingfn
approved these changes
Mar 13, 2023
| @@ -208,7 +208,9 @@ export const selectUpcomingEvents = createSelector(selectEvents, (events) => | |||
| events.filter((event) => event.isUsersUpcoming) | |||
| ); | |||
| export const selectSortedEvents = createSelector(selectEvents, (events) => | |||
There was a problem hiding this comment.
This might be out of scope, but could it be possible to add some types to these functions, to make it easier to maintain in the future?
LudvigHz
approved these changes
Mar 13, 2023
LudvigHz
deleted the
ivarnakken/aba-323-not-possible-to-edit-events-in-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was problems with storing non-serializable
momentobjects in the redux store. Issue is fixed by turning event dates into ISO strings.Multiple places used the dates directly as
momentobjects, which now needs to be wrapped in amoment()function. This is the way it's done elsewhere in our codebase.Result
Screen.Recording.2023-03-11.at.18.08.29.mov
Testing
See video above.
More testing is needed, as I was experiencing some weird behaviour.
Pages will crash if you try to perform
momentrelated functions on a string, so I need to make sure there's no such thing left.