General changes to surveys #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a "cancel" button to the editor and a "back" navigator. Other than that just styling changes.
ivarnakken
added
enhancement
ivarnakken
requested review from
erlingfn,
eikhr,
LudvigHz,
itsisak,
ollfkaih,
falbru,
Lundis1,
jennymul and
jonasdeluna
ivarnakken
force-pushed
the
survey-stuff
branch
from
a9f0f24
to
f17d14d
Compare
LudvigHz
approved these changes
Mar 14, 2023
| updateRelativeIndexes: (arg0: number, arg1: number, arg2: Fields) => void; | ||
| fields: Fields; | ||
| updateRelativeIndexes: (arg0: number, arg1: number, arg2: any) => void; | ||
| fields: any; |
There was a problem hiding this comment.
These are so difficult to type 😩
| type State = { | ||
| templatePickerOpen: boolean; | ||
| templateTypeSelected: string; | ||
| initialValues: Record<string, any>; |
There was a problem hiding this comment.
Do you know how big that object is? I'm not typing that
| <ul className={styles.questions} key="questions"> | ||
| {fields.map((question, i) => ( | ||
| <Question | ||
| key={i} |
ivarnakken
force-pushed
the
survey-stuff
branch
from
f17d14d
to
8fca652
Compare
ivarnakken
force-pushed
the
survey-stuff
branch
from
8fca652
to
bee93d3
Compare
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor changes to surveys pages
Add a "cancel" button to the editor and a "back" navigator.
Other than that just styling changes.
Rewrite survey editor to a functional component
Migrate survey editor to react-final-form
Testing
The changes to the
<Field />component has been checked with fields inredux-formforms using theonChangeprop.Editing works for the three different options; radio buttons, check boxes and text areas.
Related to ABA-54 (
redux-formis still used on the actual survey form)