Fix bug where select blurred on select for mobile #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbye
added
review-needed
ABA-328 `react-select` does not work on mobile
This has been an issue for way to long and should be prioritised! |
ivarnakken
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Looks good! 🚀 Thanks a lot!!!
You may use ngrok (or something similar, but I don't remember what it's called - maybe localtunnel will work (?) ) to test if it works.
Or, I'm retarded, just use your local IP
ivarnakken
added
approved
|
True, could've, but there were some issues getting my phone to connect to the backend 😢 Merged anyways as if it didn't fix the bug on mobile, it fixed the bug in devtools and that's kinda nice as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When on mobile react-select would call onBlur on select. This caused the value to change, but very soon after that it would change back to the original value (empty for new fields/events)
The actual fix is only on the new line 141, the rest is improved types.
Result
Now it doesn't blur on select (which it didn't do on desktop and now doesn't on mobile either)
Testing
I have only tested it on the edit event view, but I assume that it will work the same way everywhere it is used.
It is not actually tested on mobile, only on chrome devtools, but the bug was there to begin with so I hope this will also resolve it for mobile.
Resolves ABA-328