Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General changes to the interest form #3679

Merged
merged 2 commits into from Mar 15, 2023
Merged

General changes to the interest form #3679

merged 2 commits into from Mar 15, 2023

Conversation

ivarnakken
Copy link
Member

Description

Minor changes to the interest form

  • Add a helmet
  • Make header look like other headers
  • readmify some text
  • Minor changes to some labels (especially the English translations)

Migrate interest form to react-final-form

Testing

  • I have thoroughly tested my changes.

Tried to create an interest, also with "extra comments".

Resolves ABA-58

@ivarnakken
Minor changes to the interest form
08e55cc 
- Add a helmet
- Make header look like other headers
- readmify some text
- Minor changes to some labels (especially the English translations)
@ivarnakken
Migrate interest form to react-final-form
ef674cd
@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review chore Pull requests that does something "boring", yet important, e.g. cleaning up code labels Mar 14, 2023
@ivarnakken ivarnakken self-assigned this Mar 14, 2023
@linear
Copy link

linear bot commented Mar 14, 2023

ABA-58 react-final-form in company interest form

ollfkaih
ollfkaih approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@ollfkaih ollfkaih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like better language all around

@ivarnakken ivarnakken changed the title Minor changes to the interest form General changes to the interest form Mar 14, 2023
norbye
norbye approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final-form chunk was a bit annoying to view, so I skipped it(: but I liked the rest of it 🚢

@ivarnakken
Copy link
Member Author

The final-form chunk was a bit annoying to view, so I skipped it(: but I liked the rest of it 🚢

@norbye, you removed whitespace, right? It helps a ton.

image

@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Mar 14, 2023
Arashfa0301
Arashfa0301 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@Arashfa0301 Arashfa0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, looks good 👍

@norbye
Copy link
Member

norbye commented Mar 14, 2023

@norbye, you removed whitespace, right? It helps a ton.

TIL, thanks(:

@ivarnakken ivarnakken added the ready-to-merge Pull requests that have been approved and are ready to be merged label Mar 15, 2023
@ivarnakken ivarnakken merged commit 101ace0 into master Mar 15, 2023
@ivarnakken ivarnakken deleted the changes-to-interest-form branch March 15, 2023 22:21
@ivarnakken ivarnakken mentioned this pull request Mar 15, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbye norbye norbye approved these changes

@ollfkaih ollfkaih ollfkaih approved these changes

@Arashfa0301 Arashfa0301 Arashfa0301 approved these changes

@eikhr eikhr Awaiting requested review from eikhr

@itsisak itsisak Awaiting requested review from itsisak

@danielyanghansen danielyanghansen Awaiting requested review from danielyanghansen

@falbru falbru Awaiting requested review from falbru

@Lundis1 Lundis1 Awaiting requested review from Lundis1

@jennymul jennymul Awaiting requested review from jennymul

@jonasdeluna jonasdeluna Awaiting requested review from jonasdeluna

Assignees

@ivarnakken ivarnakken

Labels
approved Pull requests that have been approved chore Pull requests that does something "boring", yet important, e.g. cleaning up code enhancement Pull requests that make enhancements, instead of just purely new features ready-to-merge Pull requests that have been approved and are ready to be merged
Projects
None yet
Milestone
No milestone
4 participants
@ivarnakken @norbye @ollfkaih @Arashfa0301