Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checbox look disabled when it's disabled #3680

Merged

Conversation

ivarnakken
Copy link
Member

Description

Also decrease the transition time.

Result

Before

Screen.Recording.2023-03-14.at.17.28.28.mov

After

Screen.Recording.2023-03-14.at.17.27.12.mov

Testing

  • I have thoroughly tested my changes.

Only styling changes, and the result is shown above.

Also decrease the transition time.
@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small labels Mar 14, 2023
@ivarnakken ivarnakken self-assigned this Mar 14, 2023
@linear
Copy link

linear bot commented Mar 14, 2023

ABA-324 Disabled checkbox should look disabled

It doesn't have any specific styling, but it should. The "disabled look" should resemble the disabled look of the text input fields.

Copy link
Member

@ingraso ingraso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🚀

@LudvigHz LudvigHz merged commit 1f83fc6 into master Mar 14, 2023
@LudvigHz LudvigHz deleted the ivarnakken/aba-324-disabled-checkbox-should-look-disabled branch March 14, 2023 16:50
@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug enhancement Pull requests that make enhancements, instead of just purely new features small-fix Pull requests that fix something small
Projects
None yet
3 participants