Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize the use of border-radius #3687

Merged
merged 1 commit into from Mar 15, 2023
Merged

Standardize the use of border-radius #3687

merged 1 commit into from Mar 15, 2023

Conversation

ivarnakken
Copy link
Member

Description

It is now set globally by three variables.

Makes the webapp look less random, and it's now much easier to change the radius if we want to.

Testing

  • I have thoroughly tested my changes.

Went through ALL uses of border-radius.

@ivarnakken
Standardize the use of border-radius
fa72b81 
It is now set globally by three variables.

Makes the webapp look less random, and it's now much
easier to change the radius if we want to.
@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review chore Pull requests that does something "boring", yet important, e.g. cleaning up code labels Mar 15, 2023
@ivarnakken ivarnakken self-assigned this Mar 15, 2023
@linear
Copy link

linear bot commented Mar 15, 2023

ABA-325 Standardize border-radius

Should be a global variable, and be employed in more places.

LudvigHz
LudvigHz approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Super nice 💯

I like how we're slowly approaching our own version of a tiny tailwind 🤓

app/components/InfoBubble/InfoBubble.css
@@ -15,7 +15,7 @@
width: 70px;
height: 70px;
background-color: #d13c32;
border-radius: 35px;
border-radius: 50%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol nice 🏅

@ivarnakken
Copy link
Member Author

I like how we're slowly approaching our own version of a tiny tailwind 🤓

haha yes 🙈
It's so satisfying standardizing our codebase. Now, by simply changing some few variables you can change the entire look and feel of the webapp.

@ivarnakken ivarnakken added approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged and removed review-needed Pull requests that need review labels Mar 15, 2023
@ivarnakken ivarnakken merged commit e3597e3 into master Mar 15, 2023
@ivarnakken ivarnakken deleted the ivarnakken/aba-325-standardize-border-radius branch March 15, 2023 21:05
@ivarnakken ivarnakken added the technical-debt Pull requests that reduces technical debt label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz LudvigHz approved these changes

Assignees

@ivarnakken ivarnakken

Labels
approved Pull requests that have been approved chore Pull requests that does something "boring", yet important, e.g. cleaning up code enhancement Pull requests that make enhancements, instead of just purely new features ready-to-merge Pull requests that have been approved and are ready to be merged technical-debt Pull requests that reduces technical debt
Projects
None yet
Milestone
No milestone
2 participants
@ivarnakken @LudvigHz