Make radio buttons in interest form work #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They did not work due to `type="radio` being passed, since this causes, `react-final-form` to include a `checked` prop as well. There was also a seperate bug with the "office in Trondheim" question not working, since you the object keys were booleans.
ivarnakken
added
review-needed
ivarnakken
commented
Mar 19, 2023
| @@ -58,7 +58,7 @@ const mapStateToProps = (state, props) => { | |||
| checked: false, | |||
| })), | |||
| participantRange: null, | |||
| companyTypes: null, | |||
| companyType: null, | |||
There was a problem hiding this comment.
This was misspelled, but had no affect on anything. Not sure why it is even needed.
ivarnakken
commented
Mar 19, 2023
| @@ -660,7 +659,7 @@ const CompanyInterestPage = (props: Props) => { | |||
|
|
|||
| return ( | |||
| <Content> | |||
| <Helmet title="Bedriftsinteresse" /> | |||
| <Helmet title={isEnglish ? 'Company interest' : 'Bedriftsinteresse'} /> | |||
There was a problem hiding this comment.
Unrelated, but just nice to have.
ivarnakken
added
priority:high
ivarnakken
deleted the
ivarnakken/aba-337-radio-buttons-dont-work-on-interest-form
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
They did not work due to
type="radiobeing passed, since this causes,react-final-formto include acheckedprop as well.There was also a seperate bug with the "office in Trondheim" question not working, since the object keys were booleans.
Testing
I created and edited interest forms. I especially tested the "office in trondheim" question.