Change random bits and pieces #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of changes that are too tiny that they don't deserve their own commit/PR.
ivarnakken
added
enhancement
ivarnakken
commented
Mar 19, 2023
| @@ -354,246 +354,236 @@ export default class EventDetail extends Component<Props, State> { | |||
| ]; | |||
|
|
|||
| return ( | |||
| <div> | |||
There was a problem hiding this comment.
I just removed this useless <div>.
ivarnakken
commented
Mar 19, 2023
| @@ -16,7 +16,7 @@ | |||
| } | |||
|
|
|||
| .fieldError { | |||
| height: 35px; | |||
| min-height: 35px; | |||
There was a problem hiding this comment.
Caused overflow issues:
ivarnakken
commented
Mar 19, 2023
| @@ -8,4 +8,5 @@ | |||
| padding: 15px; | |||
| background-color: var(--lego-card-color); | |||
| border-top: 1px solid var(--border-gray); | |||
| border-radius: 0 0 var(--border-radius-lg) var(--border-radius-lg); | |||
There was a problem hiding this comment.
There were overflow issues on the footer:
ivarnakken
commented
Mar 19, 2023
| @@ -155,7 +155,12 @@ class CompanyInterestList extends Component<Props, State> { | |||
| return ( | |||
| <Content> | |||
| <ListNavigation title="Bedriftsinteresser" /> | |||
| <Flex className={styles.section}> | |||
| <Flex | |||
| wrap | |||
eikhr
approved these changes
Mar 20, 2023
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bunch of changes that are too tiny that they don't deserve their own commit/PR.
This is much needed imo.
Result
Too many stuff to show individually, but Iif you have any question, just let me know and I'll show the improvement. Changes should be very clear though.
Testing
Changes are all small and were easy to test.