Stop survey creator page from crashing on load #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `error` object was not a valid child of the span. Since it did not work as intended and I do not see the value in fixing it, I simply removed it. Also add a navigation tab back to the survey list, as it was much needed.
ivarnakken
added
priority:high
LudvigHz
approved these changes
Mar 29, 2023
LudvigHz
added
approved
norbye
approved these changes
Mar 29, 2023
ivarnakken
deleted the
ivarnakken/aba-354-not-possible-to-add-a-new-survey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
errorobject was not a valid child of the span. Since it did not work as intended and I do not see the value in fixing it, I simply removed it.Also add a navigation tab back to the survey list, as it was much needed.
Testing
It now does not crash.