Only calculate penalty reg time if heedPenalties #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABA-356 Event activation time is incorrect when applying penalties
Several issues:
|
ivarnakken
approved these changes
Mar 31, 2023
| @@ -477,7 +476,6 @@ const JoinEventForm = (props: Props) => { | |||
| component={TextInput.Field} | |||
| label={feedbackLabel} | |||
| className={styles.feedbackText} | |||
| fieldClassName={styles.feedbackField} | |||
There was a problem hiding this comment.
Did the css class not exist, or did you forget to remove it? Or is it used anywhere else? I'm on my phone so I can't check sorry
There was a problem hiding this comment.
yeah it doesn't exist. TS gives you an error when you use styles that don't exist :))
ivarnakken
added
types
💀 |
We don't check if the event uses penalties before calculating the activation time. Also fixes random type errors in the mix here.
LudvigHz
force-pushed
the
penalty-activation-time
branch
from
ff37cc9
to
69c6492
Compare
|
I have now tested the changes, and it was not flawless 🙃. I realized the subtraction is to "remove" the penalty hours from LEGO, so we display the actual activation time. I guess this might be more clear as well. Why we're doing it in the frontend I don't know. |
ivarnakken
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't check if the event uses penalties before calculating the
activation time. Also the calculation subtracted hours instead of adding
for some reason.
Also fixes random type errors in the mix here.
Result
The correct time is shown
Testing
Resolves ABA-356