Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a special component for an special event #3737

Merged
merged 1 commit into from Apr 1, 2023

Conversation

Arashfa0301
Copy link
Contributor

Special component for special days 馃ジ

@Arashfa0301 Arashfa0301 self-assigned this Mar 31, 2023
@github-actions github-actions bot added the review-needed Pull requests that need review label Mar 31, 2023
@Arashfa0301 Arashfa0301 force-pushed the add-specialJoinEventForm branch 3 times, most recently from 44c1129 to 0f56ba5 Compare March 31, 2023 20:11
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix date

Didn't look any at the special component tho but I'm hoping it's good

@@ -137,6 +138,12 @@ export default class EventDetail extends Component<Props, State> {
mapIsOpen: false,
};
}
static isCorrectDate() {
// The year doesn't matter, as it only check month and day of the month
const aprilFoolsDate = moment('2023-03-01 11:00', 'YYYY-MM-DD HH:mm');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

03-01?????

04!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing my bad. Use the branch to test the special component

@Arashfa0301 Arashfa0301 force-pushed the add-specialJoinEventForm branch 2 times, most recently from fe44bf6 to 71d8f05 Compare March 31, 2023 20:31
@Arashfa0301 Arashfa0301 changed the title Implement confetti and integral problem Add a special component for an special event Apr 1, 2023
@falbru falbru merged commit 93b3177 into master Apr 1, 2023
2 checks passed
@falbru falbru deleted the add-specialJoinEventForm branch April 1, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
3 participants