Give our RadioButton a retouch #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now shares the same transition time and "bounce" as the CheckBox, which makes them resemble each other far more. Its label now aligns itself better as well.
No more custom labels.
ivarnakken
added
enhancement
ABA-135 Improve RadioButton component
Since the Checkbox component now looks flawless, the radio buttons look awful … |
ivarnakken
commented
Apr 14, 2023
| @@ -1,90 +1,95 @@ | |||
| .box { | |||
There was a problem hiding this comment.
The entire file is rewritten, so there's no need to compare changes.
ollfkaih
approved these changes
Apr 15, 2023
LudvigHz
approved these changes
Apr 15, 2023
| label="Frist" | ||
| checked={order.deadline} | ||
| onChange={() => { | ||
| props.history.push({ |
There was a problem hiding this comment.
Would be nice if you could replace these with replace as well 😄
There was a problem hiding this comment.
Out of scope here. Write it up as a todo and we can go over all of these
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It now shares the same transition time and "bounce" as the
CheckBox, which makes them resemble each other far more.
Its label now aligns itself better as well.
Result
Before
Screen.Recording.2023-04-15.at.00.14.08.mov
After
Screen.Recording.2023-04-15.at.00.10.55.mov
Screen.Recording.2023-04-15.at.00.11.38.mov
Testing
Tested radio buttons in and outside of forms.