Type and rewrite components as function-components #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
added
types
eikhr
requested review from
LudvigHz,
danielyanghansen,
juniwbjerde,
ivarnakken and
jonasdeluna
eikhr
changed the title
eikhr
force-pushed
the
functional-components
branch
from
3f5c1ae
to
d558e09
Compare
ivarnakken
approved these changes
Apr 16, 2023
Comment on lines
+28
to
+31
| export type EmojiWithReactionData = Emoji & { | ||
| hasReacted: boolean; | ||
| reactionId: ID; | ||
| }; |
There was a problem hiding this comment.
Perhaps move this to a dedicated models file, since it is used other places?
eikhr
force-pushed
the
functional-components
branch
2 times, most recently
from
c0b501c
to
0e27d20
Compare
LudvigHz
approved these changes
Apr 17, 2023
Comment on lines
+68
to
+69
| e.target instanceof Node && | ||
| nodeRef.current.contains(e.target) |
There was a problem hiding this comment.
nodeRef is a ref to the current emoji-picker div-element
e.target is the thing that was clicked
If we click inside the emoji-picker, nodeRef.current.contains(e.target) === true, and we don't want to close it. All other clicks should close it.
eikhr
force-pushed
the
functional-components
branch
from
0e27d20
to
2fea5f2
Compare
eikhr
force-pushed
the
functional-components
branch
from
2fea5f2
to
23d898e
Compare
LudvigHz
added
review-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comment-component to a function component and typed it's props plus some props in other related components.QuoteandQuoteListcomponents.Reaction- andReactions-components as functions, and typed a bunch of reaction related stuffreactionentity-reducer from redux, and improved state type formutateReactionsmutator.MeetingAnswera function-component. Spent some time looking at theMeetingAnswer-component that had a few bugs.For reviewing I highly recommend selecting "No whitespace" as refactoring like this often changes the indentation level, leading to huge amounts of whitespace changes.
Result
We are now under 1000 ESLint warnings! 馃コ
And here is the
MeetingAnswer-screen, which now works (it only shows up when not logged in)Before:
After: (it now shows if you accepted or declined, and the login-button works)
Poem
馃 Generated by Copilot at 3f5c1ae
Testing
I've been clicking around the pages, making sure I didn't make any functional changes.
Resolves webkom/lego#2891