Fix crash on event administrate page #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
requested review from
AdrianAndersen,
LudvigHz,
itsisak,
ivarnakken and
jonasdeluna
ivarnakken
added
priority:high
ivarnakken
approved these changes
Apr 17, 2023
ivarnakken
added
approved
LudvigHz
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So I changed the
RouteWrapper-component to not pass down extra props from itself to the route-component in #3706. Turns out the event-administrate route was relying on this behaivour to pass the event and pools down to the different pages. I fixed it by making it pass down the props through thepassedProps-prop instead.I also fixed a small bug on the group-permission page where it used a css-class that did not exist, causing a crash.
Result
Two pages that used to crash immidiately, now don't!
Testing
Opened the pages and verified that they no longer crash.
Resolves ABA-399