Implement Plausible analytics into event statistics #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
future-is-now
ABA-428 Use data from Plausible on event statistics
Only the amount of visitors over time. Very useful for PR. |
LudvigHz
reviewed
Apr 26, 2023
| @@ -418,3 +419,13 @@ export function isUserFollowing(eventId: number): Thunk<any> { | |||
| }, | |||
| }); | |||
| } | |||
| export function fetchAnalytics(eventId: ID): Thunk<Promise<Action>> { | |||
There was a problem hiding this comment.
Since you're using the data from this directly, it would be nice if you could type this properly :)
There was a problem hiding this comment.
I typed it now, but to do so I had to make a bunch of changes to the call api. Take a look.
There was a problem hiding this comment.
I removed the typing commit since it didn't work and got out of scope here. You can now find it on branch type-actions.
|
I also think you can just remove the visit time thing. It's not very useful at all. |
ivarnakken
force-pushed
the
ivarnakken/aba-428-use-data-from-plausible-on-event
branch
from
1ed4a9e
to
6a62de2
Compare
ivarnakken
force-pushed
the
ivarnakken/aba-428-use-data-from-plausible-on-event
branch
2 times, most recently
from
645de7d
to
3e37e18
Compare
ivarnakken
force-pushed
the
ivarnakken/aba-428-use-data-from-plausible-on-event
branch
2 times, most recently
from
cdac1be
to
f163acf
Compare
LudvigHz
reviewed
Apr 28, 2023
ivarnakken
force-pushed
the
ivarnakken/aba-428-use-data-from-plausible-on-event
branch
from
f163acf
to
134dfc9
Compare
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Plausible analytics into event statistics
Very useful for publicity.
Considering removing "event duration" later since it doesn't really make sense.
Might also implement "bounce rate", but not sure how useful that is.
Result
Testing
Since it's a new feature, it should not break anything else.