Fix frontpage not loading correctly after logging in #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
added
review-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug where the frontpage doesn't reload after logging in, so some data is missing. The poll doesn't show results, and the quotes-component looks like it is perpetually loading.
This fixes it by adding
props.loggedInto the dependency array of thewithPreparedEffectresponsible for loading the frontpage. This means the frontpage will reload every time that prop changes.Result
After the fix, the frontpage loads normally after logging in:)
Testing
Resolves ... (either GitHub issue or Linear task)