Refactor confirm modal #3876
Merged
Refactor confirm modal #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
added
review-needed
eikhr
force-pushed
the
refactor-modal-dropdown
branch
from
5676480
to
2deddae
Compare
LudvigHz
reviewed
May 8, 2023
ivarnakken
approved these changes
May 8, 2023
ivarnakken
added
types
eikhr
force-pushed
the
refactor-modal-dropdown
branch
2 times, most recently
from
173bcc7
to
2c9b7f9
Compare
eikhr
force-pushed
the
refactor-modal-dropdown
branch
from
2c9b7f9
to
16a59f6
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
ConfirmModalWithParent-component which used a lot of confusing higher-order-component trickery with a simpler functional component. The refactored component uses the Function as Child Component pattern to pass aopenConfirmModal-function to the children, allowing f.ex. a button to open the modal. This makes for way more readable code imo.Also rewrote the modal logic from class-component to function with hooks.
Aaand I also did the same thing for
AttendanceModalResult
No visual or functional changes, just cleaner code 馃Ъ
Testing
I have tested multiple confirm modals to ensure no changes in behaviour. I have also double-checked that I set the onClick correctly in all the usages of the new component.
Resolves ... (either GitHub issue or Linear task)