Add useTheme-hook and rewrite stuff to function-components #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
added
review-needed
eikhr
requested review from
PeterJFB,
LudvigHz,
danielyanghansen,
Arashfa0301 and
jonasdeluna
eikhr
force-pushed
the
useTheme-util
branch
2 times, most recently
from
0398643
to
9ef622c
Compare
eikhr
added
the
do-not-merge/WIP
None of the ref stuff worked, so I rewrote the form-reset thing by adding a key, and the skipCaptcha thing seems to work without any code in the Captcha component
eikhr
removed
the
do-not-merge/WIP
juniwbjerde
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple places where we were manually keeping track of the theme using an event listener and component state. I figured we should just have a hook for it to avoid repeating logic. To be able to use the new hook, I had to rewrite a few class-components to functions.
Result
Only functional change should be that Captchas now update to the new theme when changing.
Testing
Resolves ... (either GitHub issue or Linear task)