Refactor DatePicker- and TimePicker-component #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
force-pushed
the
function-components
branch
3 times, most recently
from
01a13d0
to
df9a298
Compare
eikhr
force-pushed
the
function-components
branch
4 times, most recently
from
b59599d
to
aee0d4f
Compare
eikhr
added
technical-debt
eikhr
requested review from
erlingfn,
ivarnakken,
LudvigHz,
itsisak,
EliHaugu and
Lundis1
eikhr
force-pushed
the
function-components
branch
2 times, most recently
from
7b1b5ab
to
992cc72
Compare
ivarnakken
approved these changes
Jun 12, 2023
erlingfn
approved these changes
Jun 13, 2023
I'd like to add that we should extend the date picker to have a range functionality. Like this: https://ui.shadcn.com/docs/components/date-picker#date-range-picker |
ollfkaih
added
the
do-not-merge/WIP
|
@eikhr What's the status on this? I see there are some unresolved questions. |
Yep, I am going to add back the functionality for automatically moving end date forwards. Just haven't gotten around to it yet. |
eikhr
force-pushed
the
function-components
branch
from
992cc72
to
195fef6
Compare
eikhr
removed
the
do-not-merge/WIP
ivarnakken
approved these changes
Aug 23, 2023
eikhr
force-pushed
the
function-components
branch
2 times, most recently
from
f6997cf
to
f18222d
Compare
End-time is moved to the whole hour between 1 and 2 hours after the start-time, after the startTime field is blurred (deselected).
eikhr
force-pushed
the
function-components
branch
from
f18222d
to
fd78baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactor of the DatePicker thingy. Shouldn't change too much, but rewrote to functional components and simplified the logic a bit. ~100 fewer lines of code:)
Result
Some minor changes in appearance:
I have changed the behaviour slightly to simplify the logic. In the meeting editor we would previously automatically move the end time forward if it was set before the start time, but this didn't play well with the simplified component. Now it will simply show a form validation error (which is how it works in f.ex. the event-editor).The end-time auto-moving is kept intact! It now moved the end time to ~two hours after the start time when blurring (deselecting) the start time field.
Testing
I've gone through every usage of the component in the webapp, and checked manually that it still works as expected.