Replace react-hot-loader with react-refresh #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
added
future-was-2-years-ago
eikhr
requested review from
webkom-R2D2,
AdrianAndersen,
LudvigHz and
danielyanghansen
LudvigHz
reviewed
May 29, 2023
| @@ -39,6 +40,7 @@ module.exports = (env, argv) => { | |||
|
|
|||
| plugins: [ | |||
| !isProduction && new webpack.HotModuleReplacementPlugin(), | |||
| !isProduction && new ReactRefreshWebpackPlugin(), | |||
There was a problem hiding this comment.
I think so? Any reason why it wouldn't?
In my testing it works fine
There was a problem hiding this comment.
Haven't looked too much at this but I would think fast refresh needs some we apis to send the updated code? Don't know how it would do this in node? But if it's tested and its documented then that's great!
ivarnakken
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Faster, better and crashes less:)
As recommended by the author of
react-hot-loader: https://github.com/gaearon/react-hot-loader#moving-towards-next-stepResult
Better dev experience
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ... (either GitHub issue or Linear task)