Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly improve the tooltip component #3987

Merged
merged 2 commits into from
Jun 11, 2023

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    da5b34f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. Greatly improve the tooltip component

    It is now no longer super buggy!
    
    Firstly it will not overflow out of view when there is no space.
    Through the `popper` library, it will find the most suitable postion.
    No more need for the `renderDirection` prop and hacky calculations.
    
    Another nice feature is that it will point to the right direction even
    when the trigger component is flexed, which it often is. This is most
    noticeable on tables.
    
    Some minor styling changes as well, but that's not really the important
    part of this change. Worth noting that there is no longer an annoying
    buggy line between the arrow and the tooltip whenever there's a bad
    render.
    ivarnakken committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    0bccb78 View commit details
    Browse the repository at this point in the history