Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner and update public frontpage for fp-23 #4003

Merged
merged 1 commit into from Jul 2, 2023
Merged

Conversation

norbye
Copy link
Member

@norbye norbye commented Jun 18, 2023

Description

Add banner for fp-23, and change public fb-card from linking to an article to linking to ny.abakus.no.

I believe that the site is now good enough that it is better to publish it than wait, and rather iterate on the minor stuff later. Also starting to be about time that new students can find some sort of info.

Result

Banner is now visible

Testing

  • I have thoroughly tested my changes.

Resolves ... (either GitHub issue or Linear task)

@norbye norbye added review-needed Pull requests that need review small-fix Pull requests that fix something small labels Jun 18, 2023
@norbye norbye requested a review from a team June 18, 2023 21:21
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚼

Copy link
Contributor

@erlingfn erlingfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norbye norbye merged commit 054451c into master Jul 2, 2023
4 checks passed
@norbye norbye deleted the fadderperioden-23 branch July 2, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
4 participants