Refactor Sidebar #4019
Merged
Refactor Sidebar #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falbru
added
the
enhancement
falbru
force-pushed
the
refactor-sidebar
branch
2 times, most recently
from
591a282
to
91b5ae5
Compare
ivarnakken
approved these changes
Jul 4, 2023
ivarnakken
added
approved
- Refactor the Sidebar component to be a hook - The previous JSX and CSS was a mess. This looks much cleaner imo <3 - Make the sidebar fixed in mobile view in order to remove dead space. - Fix a bug where the sidebar in mobile view would overflow vertically if too many tabs where opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sidebar looks basically the same for desktop view.
Result
Desktop view
Proof that they look about the same:
Before
After
Mobile view
By making the sidebar fixed, you remove the "dead space" that would appear if a page was too long. This makes it so that the user doesn't have to scroll to the top of the page when opening the sidebar. It preserves the scroll of the page between opening and closing the sidebar.
Before
Screencast_20230704_222749-2.webm
After
Screencast_20230704_222749-3.webm
It also fixes this overflow bug as described earlier:
Testing
I have tested it with many different window sizes and tabs in the sidebar collapsed.