Let users set event location before registration type #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
review-needed
ABA-384 Let users set event location before "påmeldingstype"
For some reason I have to specify the "påmeldingstype" to be able to set a location for an event. That's kind of dumb. |
ivarnakken
commented
Jul 12, 2023
| <Field | ||
| label="Sted" | ||
| name="location" | ||
| placeholder="Den gode nabo, R5, ..." |
There was a problem hiding this comment.
Removed R5 from the placeholder, since that's part of MazeMap.
I don't see how the location has anything to do with the registration type. I have personally created an event where I knew the location but not the registration type, so this restriction is just annoying.
ivarnakken
force-pushed
the
ivarnakken/aba-384-let-users-set-event-location-before-pameldingstype
branch
from
41bd48d
to
34fa687
Compare
ivarnakken
added
approved
ivarnakken
deleted the
ivarnakken/aba-384-let-users-set-event-location-before-pameldingstype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't see how the location has anything to do with the registration type. I have personally created an event where I knew the location but not the registration type, so this restriction is just annoying.
Testing
Tested that it works to create an event with a location but without any specified registration type.