Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically align tag component on overview #4046

Merged
merged 1 commit into from Jul 16, 2023
Merged

Vertically align tag component on overview #4046

merged 1 commit into from Jul 16, 2023

Conversation

ivarnakken
Copy link
Member

Description

The display property was removed from the tag component since it could not be inline for it to work with the recent introduction of the author highlight on comments, but this broke the alignment of tags on the overview's pinned component.

Result

Before After
image image

Testing

  • I have thoroughly tested my changes.

The author tag is still aligned properly:

image

And other places where tags are used seem fine:

image image

Resolves ABA-511

The display property was removed from the tag component since it could not be inline for it to work with the recent introduction of the author highlight on comments, but this broke the alignment of tags on the overview's pinned component.
@ivarnakken ivarnakken added review-needed Pull requests that need review bug-fix Pull requests that fix a bug technical-debt Pull requests that reduces technical debt labels Jul 16, 2023
@ivarnakken ivarnakken requested a review from a team July 16, 2023 15:44
@ivarnakken ivarnakken self-assigned this Jul 16, 2023
@linear
Copy link

linear bot commented Jul 16, 2023

@ivarnakken ivarnakken added the priority:high Pull requests that have high priority, and should therefore be prioritized label Jul 16, 2023
@ivarnakken ivarnakken merged commit 4f9b3c7 into master Jul 16, 2023
4 checks passed
@ivarnakken ivarnakken deleted the align-tag branch July 16, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug priority:high Pull requests that have high priority, and should therefore be prioritized review-needed Pull requests that need review technical-debt Pull requests that reduces technical debt
Projects
None yet
1 participant