Random bits and pieces 5 #4056
Merged
Random bits and pieces 5 #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
enhancement
ivarnakken
changed the title
ollfkaih
approved these changes
Jul 22, 2023
ivarnakken
force-pushed
the
random-bits-and-pieces-5
branch
from
2ec92d3
to
2156a5c
Compare
ivarnakken
force-pushed
the
random-bits-and-pieces-5
branch
from
2156a5c
to
9bfb5d5
Compare
ivarnakken
force-pushed
the
random-bits-and-pieces-5
branch
from
9bfb5d5
to
629a0ad
Compare
They will now act as buttons, meaning you can interact with them easier, e.g. tabbing through them.
The translate(-1px) felt less modern and the icons did not have any active styling.
Less glitchy by clearing out old timeouts when creating new ones.
* Remove some use of italic fonts since that's old school * Fix glitchy render on footer * Remove some bad styling
ivarnakken
force-pushed
the
random-bits-and-pieces-5
branch
from
629a0ad
to
532a364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update some icons to behave better
They will now act as buttons, so you can tab on them.
Give icons and buttons the same "active" look
The translate(-1px) felt less modern and the icons did not have any
active styling.
Handle copy button timeouts better
Less glitchy by clearing out old timeouts when creating new ones.
Fix random bits and pieces, again
Result
Less glitchy:
Screen.Recording.2023-07-22.at.16.37.45.mov
You can now open by tabbing, and the "delete row" has a danger look:
Screen.Recording.2023-07-22.at.16.40.08.mov
Testing
Not really any breaking changes, but button and icon changes were tested on both dark and light theme.