Replace verification form with FEIDE auth #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvigHz
commented
Jul 29, 2023
Comment on lines
+467
to
+457
| endpoint: `/oidc/validate/?code=${code}&state=${state}`, | ||
| method: 'GET', |
There was a problem hiding this comment.
I'm considering changing this to a POST. There isn't really much practical difference here, more of a design choice.
There was a problem hiding this comment.
Yeah, it doesn't matter much but I think a POST would make more sense.
There was a problem hiding this comment.
I think keeping it as a GET is fine
LudvigHz
added
flawless
LudvigHz
changed the title
LudvigHz
force-pushed
the
feide
branch
4 times, most recently
from
c08ec09
to
f3a0ad3
Compare
ivarnakken
approved these changes
Aug 6, 2023
LudvigHz
force-pushed
the
feide
branch
2 times, most recently
from
8cf213f
to
5eeb4da
Compare
ivarnakken
reviewed
Aug 9, 2023
Navigation around user settings was a bit difficult and hard to find. This should make it easier to navigate to the settings page and back.
The user now just authenticates with FEIDE and we handle the rest automatically.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feide verification 😬
Result
Start page
No valid study programmes:
Screencast.from.2023-07-30.18-12-10.webm
Valid study programme:
Notice that the result from the previous verification is still present. The user may re-verify with correct data to get the proper result.
Screencast.from.2023-07-30.18-14-34.webm
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-521