Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflowing text in tooltip on event creator page #4072

Merged
merged 1 commit into from Aug 2, 2023

Conversation

ollfkaih
Copy link
Contributor

@ollfkaih ollfkaih commented Aug 2, 2023

Result

Now looks like this
Screenshot 2023-08-02 at 18 52 56
instead of this

Screenshot 2023-07-22 at 18 20 45

Testing

Looks good on various screen sizes

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ABA-517

@ollfkaih ollfkaih added review-needed Pull requests that need review bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small labels Aug 2, 2023
@linear
Copy link

linear bot commented Aug 2, 2023

ABA-517 Bad text breaking in tooltip with links

On /events/create there is a tooltip that pops over a box one has to check, which has bad word breaking.

Screenshot 2023-07-22 at 18.20.45.png

Potentially introduced recently in #3987

@ollfkaih ollfkaih changed the title Fix overflowing text in tooltip Fix overflowing text in tooltip on event creator page Aug 2, 2023
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶🏼

Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
You could instead wrap the content in a <div> to avoid the flex positioning. I don't really love inline css, but it's up to you. I think this is fine too.

@ollfkaih ollfkaih merged commit 7e699f1 into master Aug 2, 2023
4 checks passed
@ollfkaih ollfkaih deleted the overflow-event-creator branch August 2, 2023 17:45
@ollfkaih
Copy link
Contributor Author

ollfkaih commented Aug 2, 2023

Nice!
You could instead wrap the content in a <div> to avoid the flex positioning. I don't really love inline css, but it's up to you. I think this is fine too.

Yeah, I do agree about inline css, but using a div as a wrapper would add more lines (depends on line length and prettier, I guess). Lots of divs make the document tree really messy also (which I guess it already is).
I was thinking about maybe looking for other uses of the <Tooltip> where this could be an issue and maybe just add a prop to it, but decided not to dig into it.

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE WORK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
4 participants