New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create component library lego-bricks #4073
Conversation
ABA-524 Create component library
We reuse the same components in multiple projects. Currently they are simply copy/pasted, which is obviously not a great solution. A package with shared components would be better. |
9704f7c
to
f405ccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't wait! 馃槏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃槑
792df96
to
1bf92b7
Compare
af449ef
to
0118778
Compare
0118778
to
9cd6930
Compare
9cd6930
to
e8007aa
Compare
Description
Adds a nested package inside lego-webapp, monorepo style, where we can put components we want to use in other projects.
I've done some webpack and typescript trickery to make hot-reload and jump-to-definition work. Not the cleanest code, but I think it's worth it to get a better dev experience. None of it is used in production anyways. For production builds we need to build
lego-bricks
first so that it can be imported like any other npm package in lego-webapp.It currently contains
LoadingIndicator
andButton
, but most components could be moved fairly easily (just a bit of work to fix all the imports). The only thing I have found so far that doesn't work is thecomposes:
feature ofpost-css
. This is because of the internal workings ofvite
, so any components that make use of this must be changed before being moved.For reviewing I would highly recommending reviewing the commits separately
Result
Hopefully everything works exactly the same as before in
lego-webapp
馃I did fix some broken
LoadingIndicator
s though, that were never loading.Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-524