Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a success card type #4077

Merged
merged 1 commit into from Aug 7, 2023
Merged

Introduce a success card type #4077

merged 1 commit into from Aug 7, 2023

Conversation

ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Aug 6, 2023

Description

Made some minor changes to the photo upload card as well.

Result

Before After
image image
image image

Testing

  • I have thoroughly tested my changes.

All other types work as before

@ivarnakken ivarnakken added review-needed Pull requests that need review new-feature Pull requests that introduce a new feature labels Aug 6, 2023
@ivarnakken ivarnakken requested review from LudvigHz and a team August 6, 2023 18:38
@ivarnakken ivarnakken self-assigned this Aug 6, 2023
Made some minor changes to the photo upload card as well.
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LudvigHz LudvigHz added review-needed Pull requests that need review approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Aug 7, 2023
@LudvigHz LudvigHz merged commit 251fb7d into master Aug 7, 2023
4 checks passed
@LudvigHz LudvigHz deleted the success-card branch August 7, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved new-feature Pull requests that introduce a new feature review-needed Pull requests that need review
Projects
None yet
2 participants