Fix production docker image #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
added
priority:high
LudvigHz
approved these changes
Aug 9, 2023
ivarnakken
approved these changes
Aug 9, 2023
ivarnakken
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Soo, yarn workspaces creates a symlink from
lego-brickstonode-modules. This doesn't work if we don't copy the actual files into the docker image.I don't love this solution, but I couldn't find a way to make yarn actually copy the files. I think perhaps a good solution would be to just build
lego-bricksinto the bundle using webpack, but it wasn't suuper simple, so I might do that later.Result
It works now:)
Testing
Built the image locally, and ran it successfully locally