Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed color on the submit button, and changed the text #4101

Merged
merged 2 commits into from Aug 23, 2023

Conversation

Lundis1
Copy link
Contributor

@Lundis1 Lundis1 commented Aug 22, 2023

Description

Before:
Screenshot 2023-08-22 at 21 47 38
Screenshot 2023-08-22 at 21 47 22

After:
Skjermbilde 2023-08-22 kl  21 41 51

Skjermbilde 2023-08-22 kl  21 42 02

The colors was strange, and the text was wrong..

Result

the colors are fixed and the text changed

Testing

  • I have thoroughly tested my changes.

Resolves ABA-551

@github-actions github-actions bot added the review-needed Pull requests that need review label Aug 22, 2023
@Lundis1 Lundis1 added the do-not-merge/WIP Pull requests that are "work in progress", and should not be merged label Aug 22, 2023
@linear
Copy link

linear bot commented Aug 22, 2023

Copy link
Contributor

@jennymul jennymul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!<3 it looks awesome:)))

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!🙌🏼

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ivarnakken ivarnakken merged commit a270e98 into master Aug 23, 2023
4 checks passed
@ivarnakken ivarnakken deleted the verify-studentbutton branch August 23, 2023 08:34
@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Aug 23, 2023
@ivarnakken
Copy link
Member

Oooooops was this a WIP? Didn't see the label on my phone here😬

@norbye
Copy link
Member

norbye commented Aug 23, 2023

Oooooops was this a WIP? Didn't see the label on my phone here😬

Imagine creating all those nice labels and then not looking at them 🫣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved do-not-merge/WIP Pull requests that are "work in progress", and should not be merged
Projects
None yet
5 participants