Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navlinks to use gap instead of margin #4157

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

norbye
Copy link
Member

@norbye norbye commented Oct 2, 2023

Give navlinks vertical distance when they wrap.

Description

Smol visible change

Result

Before

image

After:

image

Testing

  • I have thoroughly tested my changes.

Visited a few places they were used on mobile and desktop sizes - seems okidoks to me


Give navlinks vertical distance when they wrap.
@norbye norbye added the bug-fix Pull requests that fix a bug label Oct 2, 2023
@norbye norbye added the review-needed Pull requests that need review label Oct 2, 2023
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bien!❤️

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Oct 2, 2023
@norbye
Copy link
Member Author

norbye commented Oct 2, 2023

Muy bien!❤️

image

@norbye norbye removed the review-needed Pull requests that need review label Oct 2, 2023
@norbye norbye merged commit 46a0e4c into master Oct 2, 2023
4 checks passed
@norbye norbye deleted the navlink-margin branch October 2, 2023 08:47
@norbye norbye mentioned this pull request Oct 3, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug
Projects
None yet
2 participants