Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention lego-bricks in main README.md #4159

Merged
merged 1 commit into from Oct 6, 2023
Merged

Mention lego-bricks in main README.md #4159

merged 1 commit into from Oct 6, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Oct 2, 2023

Description

Add stuff to readme

@norbye norbye added review-needed Pull requests that need review docs Pull requests that update or add documentation labels Oct 2, 2023
ivarnakken
ivarnakken reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to have!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
danielyanghansen
danielyanghansen approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For some reason, it's only necessary to manually build bricks once, and then it builds automatically later.
Don't know if that's necessary to mention

@norbye norbye added approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged and removed review-needed Pull requests that need review labels Oct 6, 2023
@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 6, 2023
@norbye norbye enabled auto-merge October 6, 2023 10:51
@norbye norbye merged commit 9d86e17 into master Oct 6, 2023
4 checks passed
@norbye norbye deleted the brick-readme branch October 6, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken left review comments

@danielyanghansen danielyanghansen danielyanghansen approved these changes

@eikhr eikhr Awaiting requested review from eikhr

Assignees
No one assigned
Labels
approved Pull requests that have been approved docs Pull requests that update or add documentation ready-to-merge Pull requests that have been approved and are ready to be merged review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
3 participants
@norbye @danielyanghansen @ivarnakken