New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tags inline-flex instead of flex #4160
Conversation
ABA-582 Misalignment and weird behaviour of tags
Should be vertically aligned and not fill the entire space: They need some spacing here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!🏅
I believe this was changed because of issues with tags on pinned events/articles and the "Forfatter" tag on comments. Do you mind checking that?
Absolutely, updated the description with screenshots of that now. Can't see any differences |
Thanks. I don't get when this was introduced though - I assume it was when I changed it, but I was certain I checked everything 🤔 🤔 🤔 |
Hmm yeah curious.. I'll make sure to check that I get the same results in staging when merging this so we can leave this to rest. |
Description
Makes tags take up only the space they need, and as such avoid the "bugs" that have been occurring on the website as of late when tags take up too much space or do not adhere to margins/gaps.
Result
Testing
Visited all the places I could find that tags are used locally, and it seemed to work quite nice.
Resolves ABA-582