Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tags inline-flex instead of flex #4160

Merged
merged 1 commit into from Oct 3, 2023
Merged

Make tags inline-flex instead of flex #4160

merged 1 commit into from Oct 3, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Oct 3, 2023

Description

Makes tags take up only the space they need, and as such avoid the "bugs" that have been occurring on the website as of late when tags take up too much space or do not adhere to margins/gaps.

Result

Before After
Admin email-lists image image
Admin email-users image image
Admin restricted-mail image image
Articles-overview image image
New joblistings image image
Author comment on event image image
Tag on pinned event Not sure if this is even possible hmm
Tag on pinned article image image
Tag on article image image

Testing

  • I have thoroughly tested my changes.

Visited all the places I could find that tags are used locally, and it seemed to work quite nice.


Resolves ABA-582

@norbye norbye added review-needed Pull requests that need review bug-fix Pull requests that fix a bug labels Oct 3, 2023
@linear
Copy link

linear bot commented Oct 3, 2023

ABA-582 Misalignment and weird behaviour of tags

Should be vertically aligned and not fill the entire space:

image.png

They need some spacing here:

image.png

Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!🏅
I believe this was changed because of issues with tags on pinned events/articles and the "Forfatter" tag on comments. Do you mind checking that?

@norbye
Copy link
Member Author

norbye commented Oct 3, 2023

Awesome!🏅 I believe this was changed because of issues with tags on pinned events/articles and the "Forfatter" tag on comments. Do you mind checking that?

Absolutely, updated the description with screenshots of that now. Can't see any differences

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Oct 3, 2023
@ivarnakken
Copy link
Member

Absolutely, updated the description with screenshots of that now. Can't see any differences

Thanks. I don't get when this was introduced though - I assume it was when I changed it, but I was certain I checked everything 🤔 🤔 🤔

@norbye
Copy link
Member Author

norbye commented Oct 3, 2023

Thanks. I don't get when this was introduced though - I assume it was when I changed it, but I was certain I checked everything 🤔 🤔 🤔

Hmm yeah curious.. I'll make sure to check that I get the same results in staging when merging this so we can leave this to rest.

@norbye norbye added ready-to-merge Pull requests that have been approved and are ready to be merged and removed review-needed Pull requests that need review labels Oct 3, 2023
@norbye norbye merged commit e72684f into master Oct 3, 2023
4 checks passed
@norbye norbye deleted the tag-bugfix branch October 3, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug ready-to-merge Pull requests that have been approved and are ready to be merged
Projects
None yet
3 participants