Fix adding new company through interest form #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
requested review from
JonasBak,
Bestem0r,
danielyanghansen,
falbru,
juniwbjerde and
ivarnakken
eikhr
force-pushed
the
fix-company-interest-new-company
branch
from
6b23920
to
d180b23
Compare
eikhr
force-pushed
the
fix-company-interest-new-company
branch
from
d180b23
to
16a86b4
Compare
eikhr
force-pushed
the
fix-company-interest-new-company
branch
from
16a86b4
to
c4d71c7
Compare
ollfkaih
approved these changes
Oct 3, 2023
ivarnakken
approved these changes
Oct 3, 2023
Comment on lines
+110
to
+121
| props.isMulti = true; | ||
| } | ||
|
|
||
| if (creatable) { | ||
| return ( | ||
| <div className={style.field}> | ||
| <Creatable | ||
| {...props} | ||
| isDisabled={disabled} | ||
| placeholder={!disabled && placeholder} | ||
| instanceId={name} | ||
| isMulti | ||
| isMulti={props.isMulti} |
There was a problem hiding this comment.
Picky, but might as well destruct it from props as well like the others
Comment on lines
+362
to
+363
| const companyId = nameOnly ? null : company['value']; | ||
| const companyName = nameOnly ? company['label'] : ''; |
There was a problem hiding this comment.
Suggested change
| const companyId = nameOnly ? null : company['value']; | |
| const companyName = nameOnly ? company['label'] : ''; | |
| const companyId = nameOnly ? null : company.value; | |
| const companyName = nameOnly ? company.label : ''; |
Any specific reason for using squared brackets?
There was a problem hiding this comment.
not really, just didn't change it
| @@ -447,6 +459,7 @@ const CompanyInterestPage = (props: Props) => { | |||
| filter={['companies.company']} | |||
| fieldClassName={styles.metaField} | |||
| component={SelectInput.AutocompleteField} | |||
| creatable | |||
There was a problem hiding this comment.
Why not set the tags prop here? Isn't that what we want?
There was a problem hiding this comment.
I assumed the tags-prop was referring to the fact that you can create new tags in tag-selectors. So I figured we should call it something else, as we might want to create other things than tags. Is there some other reason it's called that?
| return [false, 'Du må velge en bedrift'] as const; | ||
| } else if (value['__isNew__'] || !value.value) { | ||
| return [!!value.label, 'Ny bedrift må ha et navn'] as const; | ||
| } else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think the refactor to react-final-form must have broken the feature where one could add a new company in the company interest form, if it wasn't already in our database.
Result
I made some small front-end only changes to make it send the new company name in the correct format.
Testing
I have sent in a few company interest forms to test. It works well when creating new company interests. It's a teensy bit buggy when editing the name, but do we ever do that?
I think it's fine for a quick fix.