Use default cursor on disabled checkboxes and radio buttons #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
review-needed
danielyanghansen
approved these changes
Oct 5, 2023
norbye
approved these changes
Oct 6, 2023
ivarnakken
force-pushed
the
checkbox-and-radiobuttons-disabled-cursor
branch
from
981e301
to
98da19e
Compare
ivarnakken
added
approved
A pointer cursor indicates to the user that the input fields can be interacted with, and should therefore be changed accordingly when they are disabled.
ivarnakken
force-pushed
the
checkbox-and-radiobuttons-disabled-cursor
branch
from
98da19e
to
fd3803d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A pointer cursor indicates to the user that the input fields can be interacted with, and should therefore be changed accordingly when they are disabled.
Result
Cursor now behaves as expected.
Testing
Tested both input fields as both disabled fields and normal fields.