Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define padding for header icons #4171

Merged
merged 1 commit into from Oct 6, 2023
Merged

Define padding for header icons #4171

merged 1 commit into from Oct 6, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Oct 6, 2023

Description

Changes:

  • Add flex-shrink: 0; to prevent profile picture to shrink to an oval when it doesn't have enough space. This rather forces the Abakus-logo to scale down if the screen is too small (however with screens that small we have bigger problems than the logo..).
  • Add padding to the button element wrapping header icons, as it was not defined (aka left up to the browser to decide). Thus caused Safari to have twice the paddings that Chrome has, and as such the header looked very off on iPhones.

Chrome's default padding for buttons is 1px 6px, so the added 0 7px looks quite similar to what it looks like in my browser - except that it's now the same across browsers.

Result

Note that the before-version doesn't look that off in this preview, but that is only because I couldn't login - and when you're not logged in it doesn't show as many icons in the header.

Before After
iPhone 13

IMG_2201

IMG_2200

Chrome devtools with the same viewport image image

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ABA-592

@linear
Copy link

linear bot commented Oct 6, 2023

ABA-592 Incorrect profile picture scale on iOS

On iOS, the profile picture in the top right corner deforms into an oval. Seems to be caused by incorrect positioning of the other header elements due to webkit.

IMG_0396.jpg

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 6, 2023
@norbye norbye requested a review from a team October 6, 2023 05:01
@norbye norbye added the bug-fix Pull requests that fix a bug label Oct 6, 2023
@norbye norbye added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Oct 6, 2023
@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 6, 2023
@norbye norbye removed the review-needed Pull requests that need review label Oct 6, 2023
@norbye norbye enabled auto-merge October 6, 2023 10:52
@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 6, 2023
@norbye norbye merged commit bb3db6d into master Oct 6, 2023
4 checks passed
@norbye norbye deleted the fix-navbar-icons branch October 6, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug review-needed Pull requests that need review
Projects
None yet
2 participants