Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of existing company in interest form #4172

Merged
merged 1 commit into from Oct 6, 2023

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Oct 6, 2023

Description

Accidentally broke the interest form. This fixes it.

Turns out the companyId is actually a string that needs to be parsed to a number.

Result

It works now.

Testing

  • I have thoroughly tested my changes.

The form now submits, and the resulting interest seems correct.

Resolves ... (either GitHub issue or Linear task)

@github-actions github-actions bot added the review-needed Pull requests that need review label Oct 6, 2023
@ivarnakken ivarnakken added priority:high Pull requests that have high priority, and should therefore be prioritized bug-fix Pull requests that fix a bug approved Pull requests that have been approved labels Oct 6, 2023
@PeterJFB PeterJFB merged commit 15be25c into master Oct 6, 2023
4 checks passed
@PeterJFB PeterJFB deleted the fix-interest-form branch October 6, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug priority:high Pull requests that have high priority, and should therefore be prioritized review-needed Pull requests that need review
Projects
None yet
5 participants